Skip to content

Ensure the flush total points statistic function works correctly when enable_auto_create_schema is false#12990

Merged
OneSizeFitsQuorum merged 1 commit intomasterfrom
flush_point_metric_auto_create_schema
Jul 23, 2024
Merged

Ensure the flush total points statistic function works correctly when enable_auto_create_schema is false#12990
OneSizeFitsQuorum merged 1 commit intomasterfrom
flush_point_metric_auto_create_schema

Conversation

@OneSizeFitsQuorum
Copy link
Copy Markdown
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum commented Jul 22, 2024

Add automatic creation logic when internal time series fail to write due to metadata issues

@OneSizeFitsQuorum
finish
2ef279f 
Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 41.77%. Comparing base (0f797e2) to head (2ef279f).
Report is 1 commits behind head on master.

Files Patch % Lines
...db/service/metrics/IoTDBInternalLocalReporter.java 0.00% 54 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #12990   +/-   ##
=========================================
  Coverage     41.76%   41.77%           
  Complexity       71       71           
=========================================
  Files          3327     3327           
  Lines        210837   210865   +28     
  Branches      25102    25103    +1     
=========================================
+ Hits          88056    88083   +27     
- Misses       122781   122782    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SpriCoder
SpriCoder approved these changes Jul 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@SpriCoder SpriCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 392625f into master Jul 23, 2024
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the flush_point_metric_auto_create_schema branch July 23, 2024 01:56
JackieTien97 pushed a commit that referenced this pull request Jul 29, 2024
@OneSizeFitsQuorum @JackieTien97
Ensure the flush total points statistic function works correctly when…
b786924 
… enable_auto_create_schema is false #12990

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
(cherry picked from commit 392625f)
JackieTien97 pushed a commit that referenced this pull request Jul 29, 2024
@OneSizeFitsQuorum @JackieTien97
Ensure the flush total points statistic function works correctly when…
5f8197e 
… enable_auto_create_schema is false #12990

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
(cherry picked from commit 392625f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SpriCoder SpriCoder SpriCoder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OneSizeFitsQuorum @SpriCoder